Added source inception dates #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
requested changes
Jun 28, 2018
nvkelso
reviewed
Jun 28, 2018
bin/docs.py
Outdated
| @@ -68,6 +68,10 @@ | |||
| if not details['edtf:deprecated'] == 'uuuu': | |||
| docs.write("* %s %s.\n" % ('This source was deprecated on', details['edtf:deprecated'])) | |||
|
|
|||
| #call out add date | |||
| if details.get('edtf:inception'): | |||
| docs.write("* %s %s.\n" % ('This source was added on', details['edtf:inception'])) | |||
There was a problem hiding this comment.
Please instead say:
- added:
YYYY-MM-DD
Like:
docs.write("* %s: %s\n" % ('added', details['edtf:inception']))
There was a problem hiding this comment.
Also update deprecated to this same format, please.
nvkelso
approved these changes
Jun 28, 2018
|
Most recent commits take care of comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121.
Added
edtf:inceptiondates for each of the source json files in this repo, ran makefile, updated README, and template file.Tagging @nvkelso for review, all files are changing.