"Permissions denied" when downloading iso

[whren]

"permission denied" for fileutils's mv/rename in the download_iso function.
This is due to the source not closed, and windows keep an handle opened on the iso.

[whren]

I need to add a src.close before the FileUtils.mv() so the http stream is cleanly closed and handle removed.
Not doing this on windows let a blocking handle on the stream, raising a 'Permission Denied' on the FileUtils.mv().

You can reproduce this issue with the following ruby code :

require 'progressbar'
require 'open-uri'
require 'fileutils'

pbar = nil
URI.parse("http://ftp.belnet.be/packages/damnsmalllinux/archive/bootfloppy-1.5.img").open(
  :content_length_proc => lambda {|t|
  if t && 0 < t
    pbar = ProgressBar.new("Fetching file", t)
    pbar.file_transfer_mode
  end
  },
  :progress_proc => lambda {|s|
    pbar.set s if pbar
  }) { |src|
  FileUtils.mv(src.path,"d:/test-temp.img")
}

=> Raise the following error : Errno::EACCES: Permission denied - (C:/Users/XXXX/AppData/Local/Temp/open-uri20120415-26192-xpsi62, d:/test-temp.img)

And confirm the resolution of the issue with the following (note the add of src.close) :

require 'progressbar'
require 'open-uri'
require 'fileutils'

pbar = nil
URI.parse("http://ftp.belnet.be/packages/damnsmalllinux/archive/bootfloppy-1.5.img").open(
  :content_length_proc => lambda {|t|
  if t && 0 < t
    pbar = ProgressBar.new("Fetching file", t)
    pbar.file_transfer_mode
  end
  },
  :progress_proc => lambda {|s|
    pbar.set s if pbar
  }) { |src|
  src.close
  FileUtils.mv(src.path,"d:/test-temp.img")
}

[whren]

See 6df40d6