fix: fix error of executing end() multiple times

whxaxes · Sep 8, 2017 · dc5a8de · dc5a8de
1 parent 67eae6b
commit dc5a8de
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -103,6 +103,10 @@ module.exports = class TCPProxy extends EventEmitter {
   }
 
   end() {
+    if (!this.server) {
+      return Promise.resolve();
+    }
+
     return new Promise(resolve => {
       this.server.close(resolve);
     });

diff --git a/test/index.test.js b/test/index.test.js
@@ -34,6 +34,14 @@ describe('test/index.test.js', () => {
     assert(response.data.toString() === `hello world ${data.port}`);
   });
 
+  it('proxy should not throw error with executing end function multiple times', function* () {
+    data = yield createServer();
+    yield proxy.createProxy({ forwardPort: data.port });
+    yield proxy.end();
+    yield proxy.end();
+    yield proxy.end();
+  });
+
   it('proxy should start only one server', done => {
     co(function* () {
       data = yield createServer();