Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: validateOn add type change #8 #11

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Feat: validateOn add type change #8 #11

merged 3 commits into from
Dec 18, 2019

Conversation

luxiaobei
Copy link
Collaborator

No description provided.

why520crazy
why520crazy requested changes May 24, 2019
View reviewed changes
Copy link
Owner

@why520crazy why520crazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move setControlValidate by validateOn to _initializeFormControlValidation method, and completed unit test.

@why520crazy
Copy link
Owner

test this please

@why520crazy why520crazy merged commit 032c541 into master Dec 18, 2019
@why520crazy why520crazy deleted the validateOnChange branch December 18, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@why520crazy why520crazy why520crazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luxiaobei @why520crazy