Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for root folder when saved root folder doesn't exist #6

Closed
wAuner opened this issue Dec 10, 2018 · 10 comments
Closed

Prompt for root folder when saved root folder doesn't exist #6

wAuner opened this issue Dec 10, 2018 · 10 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@wAuner
Copy link

wAuner commented Dec 10, 2018

If your videohub is on a SMB share the app saves the path in windows format. On mac and linux this leads to the problem, that if you click on a video in the app, the video will not open in your default video player.

The solution would be to save the filepaths in the .vha file in a different format, depending on the operating system of the client. On Unix systems this will be the mounting point (mac: /Volumes, Linux: /Media/username/...)
Example:
For me this was "\\{name_of_network_share}\Plex_videos\video_folder” which works on windows.
I tried it on mac and changed that path manually to the correct mounting point on my system.
In this case “/Volumes/Plex_videos/video_folder”. Now when I click a video, it opens the video in VLC as intended.

@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

Do you mean if you create a library on Windows, and then open it on Mac/Linux?

@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

If so, then yes, this won't work - it's not an easy fix as you could mount the directory anywhere on your system, and even if you mount it in the same folder like Volumes, mac can change the name if there's other mounted shares.

One solution would be to detect if the video folder is missing, and allow you to browse to the correct mount point.

If we were to have multiple video paths for the root folder, it would be better to have it per system, rather than per OS, as the path isn't guaranteed to be the same on the same OS.

@wAuner
Copy link
Author

wAuner commented Dec 10, 2018

Good question. I can‘t remember on what os I created the hub.
Is the mounting point really that unpredictable? Shouldn‘t it be always mounted in the same place unless you mount it manually via terminal or have a directory with the exact same name mounted?

@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

Those should be the only two cases, but they're cases we need to take care of! Especially on linux, you're likely to mount it where ever you like, and each linux distro uses different mount points (/mnt, /media, /run) so we can't predict it.

And I've had MacOS mount my folder in folder-1 because the previous mount didn't unmount properly.

I'd rather let the user choose, rather than guess and get it wrong. Alternatively you could symlink all the folders to a common place! 😅

@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

Also, this would fix a nice issue of moving your library too! 😄

@wAuner
Copy link
Author

wAuner commented Dec 10, 2018

And why don‘t just parse the filename of the vha file? Easy and should work everytime

@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

The problem with that is that you don't have to keep the vha file with the actual video folder - you can choose to change it in the creation wizard!

I guess if you keep them the same in the creation wizard, we could make the assumption that files are relative to the vha file... Means you couldn't move them apart though...

@cal2195 cal2195 added bug Something isn't working good first issue Good for newcomers labels Dec 10, 2018
@cal2195 cal2195 changed the title [Bug] Problems with SMB paths on mac and linux Prompt for root folder when saved root folder doesn't exist Dec 10, 2018
@cal2195
Copy link
Collaborator

cal2195 commented Dec 10, 2018

I guess if you keep them the same in the creation wizard, we could make the assumption that files are relative to the vha file...

Would this fix your use case?

@wAuner
Copy link
Author

wAuner commented Dec 11, 2018

that would do it for me. I always created the vha files directly inside the video directories.
That would be a simple and effective solution.

@cal2195
Copy link
Collaborator

cal2195 commented Dec 11, 2018

Thanks @wAuner - I've created #7 to track this second bug.

I'll try to get it into v1.4.0! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants