Last steps before v2.0.0 release

[whyboris]

This issue is to keep a list of tasks that should be done after all the new features we'd like to see in version 2.0.0 are added, but before the release occurs. Most of these tasks are on top of the issues tagged for Milestone v2.0.0

This is a good place to see just how much needs to be done to make the current master release-ready. In no particular order:

Visual

• Reorganize the settings menu & tabs to be more coherent
• Icon overhaul Icon overhaul #51
• Confirm settings defaults - make the first app launch only display relevant buttons
• Clean up the Miscellaneous view settings - group and describe buttons better
• CSS consolidation: pull colors and some re-used elements from a central file
• reevaluate colors - maybe better contrast for a11y (accessibility) and harmonize all the filter and tag colors
• CSS consolidation: some components use the same CSS, so, reuse those to keep DRY
• confirm animations look good; add animations on newly added features

Dark Mode

• Move the dark mode button to just-before-last button in the toolbar
• Confirm app responds to OS X Dark Mode settings / changes
• Check the dark mode is working on all components; possibly simplify the CSS

Code

• Streamline the view switching code - how element widths / heights are recomputed & how ng-scroll receives the expected heights / number of elements (we now have 6 views, used to be 3)
• Remember each view's zoom level Remember Each View's Zoom Level #16
• Consolidate the view-switching bug (some views currently don't show)
• Check that all views handle window resizes and search-bar hiding
• Make sure that adding a rating, scrolling away, and scrolling back persists the rating in the view
• Remove most console.log statements
• Add new keyboard shortcuts (for new views) & update the list in settings
• Remove jankiness from the resolution, time, and rating filters

Misc

• Update to latest Angular (v8)
• Stress test the app with more than 1,000 videos in a hub

⚠️ Note -- unfinished tasks moved to #234

[cal2195]

I think the full view scrolling issue has something to do with:
https://github.com/rintoj/ngx-virtual-scroller#items-with-variable-size

I tried enabling unequal child sizes, but the detail view started acting badly! 😢

[whyboris]

The only view that has variable sizes is the full-view

Somewhere in the code for the filmstrip, thumbnail, and file views I provide to the virtual-scroller the expected number of items to display (computed based on width and height of gallery view). This hasn't been done for the other views and so they are possibly wonky.

I'll review that part of code and find a solution for every view: it's easy enough to estimate how many elements will be displayed based on the app state 👌

[cal2195]

Stress test the app with more than 1,000 videos in a hub

Phhffff 1,000? That's rookie numbers!
I can confirm it works flawlessly with 20,000+ videos in a single hub, over a network, with each video having ~20 manual tags added as well! 🚀 ⚡️

[whyboris]

😭 😁

[whyboris]

Unfinished tasks moved to #234