Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon overhaul #51

Closed
whyboris opened this issue Dec 28, 2018 · 2 comments · Fixed by #113
Closed

Icon overhaul #51

whyboris opened this issue Dec 28, 2018 · 2 comments · Fixed by #113
Labels
enhancement Improves existing features
Milestone

Comments

@whyboris
Copy link
Owner

whyboris commented Dec 28, 2018

Problem: currently we're reusing several icons as we've run out of available ones in the font file. We'll be adding more settings in the future, and it's great not to have to rebuild the icon font every time a new icon is added.

Solution: start using svg files directly (instead of a custom font that needs to be generated from the pre-made svg files).

I'll be happy to take on the task - closer to when we need to release v2.0 👍

@whyboris whyboris added this to the v2.0.0 milestone Dec 28, 2018
@cal2195 cal2195 added the enhancement Improves existing features label Dec 29, 2018
@whyboris
Copy link
Owner Author

This seems more and more pressing 😅 - we have so many new buttons, and this must be ready by release and it will take some time to craft new icons.

I'll work on this next 🏃

@whyboris whyboris moved this from To do to In progress in Boris's Current Workflow Jan 19, 2019
@whyboris whyboris mentioned this issue Jan 20, 2019
@whyboris
Copy link
Owner Author

Will be closed with #113 🎉

@whyboris whyboris moved this from In progress to In review in Boris's Current Workflow Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing features
Projects
Development

Successfully merging a pull request may close this issue.

2 participants