Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete tags when searching #65

Closed
cal2195 opened this issue Jan 2, 2019 · 10 comments · Fixed by #200
Closed

Autocomplete tags when searching #65

cal2195 opened this issue Jan 2, 2019 · 10 comments · Fixed by #200
Labels
2.0.0 Priority for v2.0.0 release feature request New features
Milestone

Comments

@cal2195
Copy link
Collaborator

cal2195 commented Jan 2, 2019

It would be a very neat feature to auto complete tags when searching from the search fields! 👍

I'm not sure how difficult this would be to implement in the current setup, but it would be worth thinking about with #53! 👍

@cal2195 cal2195 added the feature request New features label Jan 2, 2019
@cal2195 cal2195 added this to the v2.0.0 milestone Jan 2, 2019
@whyboris
Copy link
Owner

Will make sure this is part of the feature when I work on it ✅

Working on it this weekend - along with #53

@whyboris
Copy link
Owner

Oh yea! That's done 👌

@cal2195
Copy link
Collaborator Author

cal2195 commented Jan 25, 2019

Reopening as I meant this in reference to the "tag filters"! 😄

@cal2195 cal2195 reopened this Jan 25, 2019
@whyboris
Copy link
Owner

There's a bit of a tweak I'd like to work on to the auto tag filters that show up in the details view -- namely the 2-word auto-tags should show up as 2 words (rather than one).

I'll work on that part - and then later I can look into auto-completion of both manual and auto-tags in the sidebar search 👍

@cal2195
Copy link
Collaborator Author

cal2195 commented Jan 29, 2019

I wonder if we should not remove tags that are in the "two word tags" from the "one word tags" and show both in the auto tags? 💡

It makes sense to have both words as individual tags, but they also have a different meaning when they're used together! I meant to bring this up earlier! 👍 Thoughts?

@whyboris
Copy link
Owner

whyboris commented Feb 1, 2019

I forgot the current functionality -- I am removing one-word tags that appear in two-word combinations, right?

If I did that, it was likely because if I didn't the one-word-tags would grow to be at least 2x the size.

A user can add the 1-word tags manually if wanted; I am still leaning towards not adding the 2-word tags as two separate words into the 1-word tag column.

Feels faster for the user to add a few missing ones, than having to remove a large number of duplicates. Though as usual I'm not very clear about what people are using this app for 😅

@whyboris whyboris added the 2.0.0 Priority for v2.0.0 release label Feb 24, 2019
@whyboris whyboris moved this from To do backlog to To do next in Boris's Current Workflow Feb 27, 2019
@whyboris
Copy link
Owner

Hey @cal2195 -- I'm trying to finalize the app v2.0.0 and I might encroach on your tagging feature a bit. I'm sorry ahead of time if I end up reverting some of your work -- it isn't intentional.

I've not looked at the auto-generated or manually-added tag code in over a month and don't remember how some of it behaves. I'll try to fix whatever bugs I find and add whatever features we discussed above and before (unless they end up being too complex for this release).

I'd rather get everything release-ready within a week or two so I have enough time to polish off the icons and update the website (record new animations, etc).

I'll try to get all the tag bugfixes and features into a single PR and keep it open for a while so you have a time to glance at it and give me feedback -- you've done excellent work with tags and I'd rather not overwrite your intentions 🙇

Cheers 🤝

@cal2195
Copy link
Collaborator Author

cal2195 commented Feb 27, 2019

That sounds good to me! I'll have a look through the bugs now and see what I can do to help! 👍 Let me know if you'd like me to tackle anything!

Don't worry about postponing anything new or current you'd like to be more polished - gotta have something for future releases! 😉

@whyboris whyboris moved this from To do next to In progress in Boris's Current Workflow Jul 5, 2019
@whyboris
Copy link
Owner

whyboris commented Jul 5, 2019

@cal2195 you're a genius! I just noticed that if the autoFileTags is enabled (so they show up in blue in the details / edit meta view), then when you do the tag search - they are part of the search, but if you disable the autoFileTags, they are not part of the search 💥 😮 🙇

@whyboris whyboris moved this from In progress to In review in Boris's Current Workflow Jul 6, 2019
@cal2195
Copy link
Collaborator Author

cal2195 commented Jul 10, 2019

😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 Priority for v2.0.0 release feature request New features
Projects
Development

Successfully merging a pull request may close this issue.

2 participants