-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete tags when searching #65
Comments
Will make sure this is part of the feature when I work on it ✅ Working on it this weekend - along with #53 |
Oh yea! That's done 👌 |
Reopening as I meant this in reference to the "tag filters"! 😄 |
There's a bit of a tweak I'd like to work on to the auto tag filters that show up in the details view -- namely the 2-word auto-tags should show up as 2 words (rather than one). I'll work on that part - and then later I can look into auto-completion of both manual and auto-tags in the sidebar search 👍 |
I wonder if we should not remove tags that are in the "two word tags" from the "one word tags" and show both in the auto tags? 💡 It makes sense to have both words as individual tags, but they also have a different meaning when they're used together! I meant to bring this up earlier! 👍 Thoughts? |
I forgot the current functionality -- I am removing one-word tags that appear in two-word combinations, right? If I did that, it was likely because if I didn't the one-word-tags would grow to be at least 2x the size. A user can add the 1-word tags manually if wanted; I am still leaning towards not adding the 2-word tags as two separate words into the 1-word tag column. Feels faster for the user to add a few missing ones, than having to remove a large number of duplicates. Though as usual I'm not very clear about what people are using this app for 😅 |
Hey @cal2195 -- I'm trying to finalize the app v2.0.0 and I might encroach on your tagging feature a bit. I'm sorry ahead of time if I end up reverting some of your work -- it isn't intentional. I've not looked at the auto-generated or manually-added tag code in over a month and don't remember how some of it behaves. I'll try to fix whatever bugs I find and add whatever features we discussed above and before (unless they end up being too complex for this release). I'd rather get everything release-ready within a week or two so I have enough time to polish off the icons and update the website (record new animations, etc). I'll try to get all the tag bugfixes and features into a single PR and keep it open for a while so you have a time to glance at it and give me feedback -- you've done excellent work with tags and I'd rather not overwrite your intentions 🙇 Cheers 🤝 |
That sounds good to me! I'll have a look through the bugs now and see what I can do to help! 👍 Let me know if you'd like me to tackle anything! Don't worry about postponing anything new or current you'd like to be more polished - gotta have something for future releases! 😉 |
@cal2195 you're a genius! I just noticed that if the |
😇 |
It would be a very neat feature to auto complete tags when searching from the search fields! 👍
I'm not sure how difficult this would be to implement in the current setup, but it would be worth thinking about with #53! 👍
The text was updated successfully, but these errors were encountered: