Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xformers as it breaks injections module on mac #162

Merged
merged 8 commits into from
Oct 24, 2023

Conversation

jamie256
Copy link
Collaborator

Fixes #161 and also fills the gap in our CI that should have caught this:

  • remove xformers from all target, its not strictly needed and can remain as an optional dependency.
  • change the poetry dependency install cache key to include the string 'all'
  • replace the ci workflow's use of poetry install to use the make install command which aliases poetry install -E all and runs on mac

If we had run the poetry install -E all to setup the dependencies then we could have caught failures in our CI relating to the optional dependencies.

@jamie256 jamie256 force-pushed the dev/jamie/make_install_ci_xformers_fix branch from f86e318 to ccb6f61 Compare October 13, 2023 18:42
@richard-rogers
Copy link
Contributor

I think faster-fifo may be broken on Apple silicon Macs.

@jamie256 jamie256 merged commit 4e27080 into main Oct 24, 2023
12 checks passed
@jamie256 jamie256 deleted the dev/jamie/make_install_ci_xformers_fix branch October 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xformers causes crash on mac with injections
2 participants