Skip to content

Commit

Permalink
REFACTOR: remove duplicates that were already tested in test_minmax
Browse files Browse the repository at this point in the history
  • Loading branch information
TheMellyBee committed Apr 25, 2022
1 parent 608a634 commit 20d9457
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions tests/unit/core/statistics/datatypes/test_floattracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def test_merge_floattrackers_should_addup():
merge_second = second.merge(first)
assert merge_second.__dict__ == merge_first.__dict__


def test_merge_floattrackers_should_addup():
float32_tracker = FloatTracker()
float32_array = np.array([1.0, 2.0, 3.0], dtype=np.float32)
Expand All @@ -84,12 +85,6 @@ def test_merge_floattrackers_should_addup():
for val in vals2:
simple_tracker.update(val)

assert simple_tracker.count == len(vals2)
assert simple_tracker.max == max(vals2)
assert simple_tracker.min == min(vals2)
assert simple_tracker.sum == sum(vals2)


merge_32_and_simple = float32_array.tolist() + vals2
merge_first_tracker_32_and_simple = float32_tracker.merge(simple_tracker)
assert merge_first_tracker_32_and_simple.count == len(merge_32_and_simple)
Expand Down Expand Up @@ -118,4 +113,4 @@ def test_merge_floattrackers_should_addup():
assert merge_first_tracker_64_and_32.sum == sum(merge_64_and_32)

merge_second_tracker_64_and_32 = float32_tracker.merge(float64_tracker)
assert merge_first_tracker_64_and_32.__dict__ == merge_second_tracker_64_and_32.__dict__
assert merge_first_tracker_64_and_32.__dict__ == merge_second_tracker_64_and_32.__dict__

0 comments on commit 20d9457

Please sign in to comment.