Merge 27a874f into f45e104

whylabs · Mar 23, 2022 · b1b3d9f · b1b3d9f
2 parents f45e104 + 27a874f
commit b1b3d9f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/src/whylogs/viewer/templates/index-hbs-cdn-all-in-for-jupyter-notebook.html b/src/whylogs/viewer/templates/index-hbs-cdn-all-in-for-jupyter-notebook.html
@@ -773,16 +773,15 @@
                   <div class="wl-table-heading">
                     <div class="wl-table-row wl-table-row--bottom-shadow">
                       <div class="wl-table-head wl-table-head-wraper">
-                        <div class="wl-table-head table-border-none graph-table-head">Feature</div>
+                        <div class="wl-table-head table-border-none graph-table-head">Target</div>
                         <div class="wl-table-head table-border-none reference-table-head">Reference</div>
                       </div>
                       <div class="wl-table-head wl-sub-table-head text-align-center" id="diff-from-ref">
                         Diff from ref.
                         <div class="tooltip-full-number">
                             <span class="question-mark">?</span>
                           <span class="tooltiptext">
-                           <div class="mb-1">Lorem Ipsum is simply dummy</div> 
-                           <div>text of the printing and typesetting.</div>
+                           <div class="mb-1">Distance between the reference and target profiles</div>
                           </span>
                         </div>
                       </div>

diff --git a/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-bar-chart.html b/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-bar-chart.html
@@ -168,7 +168,7 @@
                   <div class="display-flex">
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #44C0E7;"></div>
-                      <text alignment-baseline="middle" style="font-size: 15px;">Current</text>
+                      <text alignment-baseline="middle" style="font-size: 15px;">Target</text>
                     </div>
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #F5843C"></div>
@@ -242,7 +242,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
              .attr("preserveAspectRatio", "xMinYMin meet")
              .attr("viewBox", `0 0 ${$(window).width()} ${$(window).height()-30}`)
              .classed("svg-content-responsive", true)
-          this.maxYValue = d3.max(data, (d) => Math.abs(d.axisY));
+          this.maxYValue = d3.max([...data, ...referenceData], (d) => Math.abs(d.axisY));
           this.xScale = d3
             .scaleBand()
             .domain(filterAndSortChartData(data, referenceData).map((sortedCounts) => sortedCounts?.axisX))
@@ -341,7 +341,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
               .attr("fill", "currentColor")
               .attr("text-anchor", "start"));
 
-        svgEl.append("text")             
+        svgEl.append("text")
           .attr("transform",
                 "translate(" + (CHART_WIDTH/2) + " ," + 
                                (CHART_HEIGHT + MARGIN.TOP + 40) + ")")

diff --git a/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-differenced-chart.html b/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-differenced-chart.html
@@ -176,7 +176,7 @@
                   <div class="display-flex">
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #44C0E7;"></div>
-                      <text alignment-baseline="middle" style="font-size: 15px;">Current</text>
+                      <text alignment-baseline="middle" style="font-size: 15px;">Target</text>
                     </div>
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #F5843C"></div>

diff --git a/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-distribution-chart.html b/src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-distribution-chart.html
@@ -175,7 +175,7 @@
                   <div class="display-flex">
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #44C0E7;"></div>
-                      <text alignment-baseline="middle" style="font-size: 15px;">Current</text>
+                      <text alignment-baseline="middle" style="font-size: 15px;">Target</text>
                     </div>
                     <div class="colors-for-distingushing-charts">
                       <div class="circle-color" style="background: #F5843C"></div>

diff --git a/src/whylogs/viewer/templates/index-hbs-cdn-all-in.html b/src/whylogs/viewer/templates/index-hbs-cdn-all-in.html
@@ -2544,7 +2544,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
       colorsForDistingushingChartHTMLElement +=`
         <p>Data Distribution Chart</p>
         <div class="display-flex">
-          ${colorsForDistingushingCharts("#369BAC", "Current")}
+          ${colorsForDistingushingCharts("#369BAC", "Target")}
           ${colorsForDistingushingCharts("#2683C9", "Reference")}
         </div>
       `