Skip to content

Commit

Permalink
style fixes
Browse files Browse the repository at this point in the history
compile protobuf files for test

fix workflow

remove example paths
  • Loading branch information
lalmei committed Aug 23, 2021
1 parent a7ac87a commit ceaddf5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/test-notebook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ jobs:
restore-keys: |
${{ runner.os }}-pip-
- name: Install dependencies
run: make install
- name: make kernel
run: |
make install
make
- name: make jupyter-kernel
run: make jupyter-kernel
- name: Run notebook test
run: make test-notebooks
Expand Down
2 changes: 1 addition & 1 deletion examples/Dataset_Profiler_Viewer.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
}
],
"source": [
"profile_viewer(profiles=[profile],output_path=\"/Users/leandro/Desktop/my_dataset.html\")"
"profile_viewer(profiles=[profile])"
]
}
],
Expand Down
11 changes: 4 additions & 7 deletions test_notebooks/notebook_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,24 @@
TEST_DIR = os.path.dirname(os.path.abspath(__file__))
PARENT_DIR = os.path.join(TEST_DIR, os.pardir)

skip_notebooks=["Guest Session Demo.ipynb",
"RAPIDS GPU Integration Example.ipynb",
"Analysis.ipynb",
"ROV-whylogs.ipynb" ]
skip_notebooks = ["Guest Session Demo.ipynb", "RAPIDS GPU Integration Example.ipynb", "Analysis.ipynb", "ROV-whylogs.ipynb"]


def process_notebook(notebook_filename, html_directory="notebook-html"):
"""
Checks if an IPython notebook runs without error from start to finish. If so, writes the
notebook to HTML (with outputs) and overwrites the .ipynb file (without outputs).
"""


with open(notebook_filename) as f:
nb = nbformat.read(f, as_version=4)

notebook_directory= os.path.abspath(os.path.dirname(notebook_filename))
os.path.abspath(os.path.dirname(notebook_filename))
ep = ExecutePreprocessor(timeout=2000, kernel_name="whylogs-dev", allow_errors=False)

try:
# Check that the notebook runs
ep.preprocess(nb, {"metadata": {"path": os.path.join(PARENT_DIR,"examples")}})
ep.preprocess(nb, {"metadata": {"path": os.path.join(PARENT_DIR, "examples")}})
except CellExecutionError:
raise

Expand Down

0 comments on commit ceaddf5

Please sign in to comment.