Add warning if using both rotation and setting dataset_timestamp (#557)

* Add warning if using both rotation and setting dataset_timestamp * update poetry cache key to use new cache and avoid is_absolute path bug
whylabs · May 11, 2022 · d732121 · d732121
1 parent 44f2183
commit d732121
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/python-continuous-integration.yml b/.github/workflows/python-continuous-integration.yml
@@ -36,8 +36,8 @@ jobs:
       uses: actions/cache@v2
       with:
         path: ~/.cache/pypoetry
-        key: ${{ runner.os }}-poetry-${{ hashFiles('**/poetry.lock') }}
-        restore-keys: ${{ runner.os }}-poetry-
+        key: ${{ runner.os }}-poetry2-${{ hashFiles('**/poetry.lock') }}
+        restore-keys: ${{ runner.os }}-poetry2-
     - name: Install dependencies
       run: make install
     - name: Run build, style, and lint checks

diff --git a/src/whylogs/app/logger.py b/src/whylogs/app/logger.py
@@ -98,6 +98,8 @@ def __init__(
             self.dataset_timestamp = datetime.datetime.now(datetime.timezone.utc)
         else:
             self.dataset_timestamp = dataset_timestamp
+            if with_rotation_time is not None:
+                self._py_logger.warning("dataset_timestamp specified with log rotation! dataset_timestamp ignored")
         self.dataset_name = dataset_name
         self.writers = writers
         self.metadata_writer = metadata_writer