make lint-fix doesn't fix linting issue

[andyndang]

Description

• This repo: https://github.com/whylabs/whylogs/tree/2dd782a3e284aa5063c5a4b0738407b7244ec6e2
• make lint-fix is a no op locally
• make format-fix doesn'tchange anything

However the CI is faiilng

- files were modified by this hook

reformatted python/tests/core/view/test_dataset_profile.py

All done! ✨ 🍰 ✨

[jamie256]

make pre-commit will fix these up, we can pipe the lint/format fix through that.

[jamie256]

Ok, I just reproduced this issue even with running pre-commit, I don't see the issue yet but see that it is an inconsistent result in running black.

[jamie256]

poetry run black --check . fails while at the same time poetry run pre-commit run --all-files runs and passes black:

[INFO] Running pre-commit checks

poetry run pre-commit run --all-files
black....................................................................Passed
flake8...................................................................Passed
isort....................................................................Passed
mypy.....................................................................Passed
prettier.................................................................Passed
check for added large files..............................................Passed
debug statements (python)................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
forbid new submodules................................(no files to check)Skipped
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed

And then poetry run black --check .

poetry run black . --check
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
would reformat whylogs/api/writer/whylabs.py

Oh no! 💥 💔 💥
1 file would be reformatted, 139 files would be left unchanged.

This happens because there is a different version of black in the poetry.lock file: 23.1a1 vs in the .pre-commit-config.yaml which has 22.3.0, and they disagree on if an empty line as first line in a function body is acceptable or not.

Will fix this by making the version of black consistent between pre-commit and poetry.