Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_or_create_session() should log when it loads configuration from a file #383

Closed
jamie256 opened this issue Dec 16, 2021 · 0 comments · Fixed by #382
Closed

get_or_create_session() should log when it loads configuration from a file #383

jamie256 opened this issue Dec 16, 2021 · 0 comments · Fixed by #382
Assignees
Labels
bug Something isn't working

Comments

@jamie256
Copy link
Contributor

Summary

When using the method without parameters, the logic for session configuration searches for special file names and attempts to load configuration from there, but it does not log where the configuration is being loaded from, leading to potentially confusing changes in behavior in environments where the existence of a configuration file changes behavior without changes in the code or indications in the log statements.

Steps to Reproduce it

create a file in your home directory named .whylogs.yaml and use our code examples with get_or_create_session() and note that we do not log where configuration is loaded from.

What is the expected correct behavior?

If configuration is loaded from files (or attempted to load) we should have some debug and info level output indicating this behavior to make it easier to understand what session configuration is loaded and from where.

@jamie256 jamie256 added the bug Something isn't working label Dec 16, 2021
@jamie256 jamie256 self-assigned this Dec 16, 2021
@jamie256 jamie256 linked a pull request Dec 16, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant