Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement: make session config loading easier to understand #382

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

jamie256
Copy link
Contributor

Description

Because our default session creation logic in get_or_create_session() looks for specially named files, it can be tricky to debug what configuration is loaded and from where it is loaded if you happen to have one of those files edited. Adding a few more log statements to avoid needing a debugger to answer questions about what configuration was loaded and where it is defined.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@jamie256 jamie256 added the maintenance maintenance issues label Dec 16, 2021
@coveralls
Copy link

coveralls commented Dec 16, 2021

Pull Request Test Coverage Report for Build 1589525350

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.145%

Totals Coverage Status
Change from base Build 1589490745: 0.01%
Covered Lines: 3731
Relevant Lines: 4521

💛 - Coveralls

@jamie256 jamie256 merged commit f6ae9c7 into mainline Dec 17, 2021
@jamie256 jamie256 deleted the dev/jamie/config_load_debug branch December 17, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_or_create_session() should log when it loads configuration from a file
3 participants