Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the value constraint report in the ValueConstraintMsg #445

Closed
jamie256 opened this issue Feb 17, 2022 · 1 comment
Closed

Include the value constraint report in the ValueConstraintMsg #445

jamie256 opened this issue Feb 17, 2022 · 1 comment
Assignees
@pecop2
Labels
feature

Comments

@jamie256
Copy link
Contributor

Value constraints require the raw data to run, so the report they produce which includes the number of failures should be part of the serialized form which would allow user to inspect the serialized messages without requiring the raw data again in order to determine pass / fail or report the number of failures to a dashboard.
@pecop2 pecop2 mentioned this issue Feb 22, 2022
Merged
4 tasks
jamie256 pushed a commit that referenced this issue Feb 22, 2022
@pecop2
Total executions and failures included in value constraints proto mes…
224230c 
…sages (#450)

* Add total executions and failures in ValueConstraintMsg

* Edit from_protobuf to use the total executions and failures

addresses #445

Co-authored-by: pecop2 <petar@loka.com>
@jamie256
Copy link
Contributor Author

this is in whylogs 0.6.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pecop2 pecop2

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pecop2 @jamie256