UDF signature update & Python data types #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-rogers
requested review from
bernease,
andrewelizondo,
FelipeAdachi and
jamie256
richard-rogers
commented
Jul 13, 2023
richard-rogers
commented
Jul 13, 2023
richard-rogers
commented
Jul 13, 2023
richard-rogers
commented
Jul 13, 2023
richard-rogers
commented
Jul 13, 2023
FelipeAdachi
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes dataset and type UDF signatures so that they can be coded to ignore whether they're called with a row or
DataFrame. Also allows type-matchingResolverSpecs to use Python types rather than whylogsDataType.Changes
Dataset UDF signature is
udf(x: Union[Dict[str, List], pd.DataFrame]) -> Union[List, pd.Series]Type UDF signature is
udf(x: Union[List, pd.Series]) -> Union[List, pd.Series]UNCHANGED: metric UDF signature remains
udf(x: Any) -> Any, where the Anys are single values in a row.UdfSpecandResolverSpecmatching by type can now use native Python types via aTypeMapperin addition to the whylogsDataTypeI have reviewed the Guidelines for Contributing and the Code of Conduct.