Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction updates #1464

Merged
merged 5 commits into from Feb 20, 2024
Merged

Transaction updates #1464

merged 5 commits into from Feb 20, 2024

Conversation

richard-rogers
Copy link
Contributor

  • More transaction integration tests
  • support for distributed transactions
  • Transaction context manager

jamie256
jamie256 reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready? I think we're waiting on pending changes.

jamie256
jamie256 requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the exception handling in the log statement first, otherwise looks ok.

python/whylogs/api/writer/whylabs.py Outdated Show resolved Hide resolved
jamie256
jamie256 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit 06b15fd into mainline Feb 20, 2024
19 checks passed
@jamie256 jamie256 deleted the dev/richard/trans2 branch February 20, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@FelipeAdachi FelipeAdachi Awaiting requested review from FelipeAdachi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richard-rogers @jamie256