Fix bug that prevents prefixes from being omitted in udfs #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types for a udf schema allow the prefix to be None, but our code doesn't work in that scenario. In addition, the annotation interface for udfs don't even let you have a None prefix. This change fixes both of those issues.
naddeoa
force-pushed
the
omit-udf-prefix
branch
from
ebf554e
to
f8ff9a7
Compare
jamie256
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types for a udf schema allow the prefix to be None, but our code doesn't work in that scenario. In addition, the annotation interface for udfs don't even let you have a None prefix. This change fixes both of those issues.