Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ notebook tests #147

Merged
merged 5 commits into from
Apr 8, 2021
Merged

✅ notebook tests #147

merged 5 commits into from
Apr 8, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Feb 5, 2021

No description provided.

@coveralls
Copy link

coveralls commented Mar 8, 2021 •
edited

Pull Request Test Coverage Report for Build 683671998

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.326%
Totals Coverage Status
Change from base Build 680443847: -0.01%
Covered Lines: 3110
Relevant Lines: 3546
💛 - Coveralls

@lalmei lalmei changed the title [WIP] ✅ notebook tests ✅ notebook tests Mar 24, 2021
@lalmei lalmei requested review from cswarth and bernease March 24, 2021 16:33
@bernease
Copy link
Contributor

I can do a review now.

@lalmei lalmei requested a review from naddeoa April 7, 2021 22:57
andyndang
andyndang approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit b6a2638 into mainline Apr 8, 2021
@lalmei lalmei deleted the WHY-2304_notebook_tests branch May 1, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyndang andyndang andyndang approved these changes

@phantomgoose phantomgoose Awaiting requested review from phantomgoose

@cswarth cswarth Awaiting requested review from cswarth

@bernease bernease Awaiting requested review from bernease

@naddeoa naddeoa Awaiting requested review from naddeoa

Assignees
No one assigned
Labels
integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lalmei @coveralls @bernease @andyndang