ranking example rewrite #1488
Merged
ranking example rewrite #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2024 16:16
# Conflicts: # python/examples/experimental/Writing_Ranking_Performance_Metrics_to_WhyLabs.ipynb
added 2 commits
March 19, 2024 17:43
richard-rogers
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should be merged after we merge #1486
And after we release next whylogs version, considering the version is pinned in the example to
1.3.27In addition to the example rewrite, this PR:
changes the semantics for
prediction_columnfor the numeric case, when passing it in along with thetargets_column. It used to interpret the column as indices to the targets column, now it's interpreted as ranksI have reviewed the Guidelines for Contributing and the Code of Conduct.