Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking metrics API improvements #1507

Merged
merged 6 commits into from Apr 25, 2024
Merged

Ranking metrics API improvements #1507

merged 6 commits into from Apr 25, 2024

Conversation

richard-rogers
Copy link
Contributor

Description

Removes the convert_non_numeric argument and swap prediction_column for target_column when only relevance scores are passed.

Changes

  • Determines convert_non_numeric automatically by looking for strings in the prediction & target columns
  • Swap prediction_column and target_column when only one column name is passed

Closes #1504
Closes #1505

murilommen
murilommen previously approved these changes Apr 25, 2024
Copy link
Contributor

@murilommen murilommen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small comment

Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richard-rogers richard-rogers merged commit b91949f into mainline Apr 25, 2024
19 checks passed
@richard-rogers richard-rogers deleted the dev/richard/1505 branch April 25, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants