Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README in pypi #219

Merged
merged 2 commits into from
May 2, 2021
Merged

Fix README in pypi #219

merged 2 commits into from
May 2, 2021

Conversation

andyndang
Copy link
Contributor

@andyndang andyndang commented May 2, 2021

The images are broken so we'll need to figure out a solution long term.

pypi/warehouse#5246

PyPI does not support rendering from the package path itself, as it is not an image host.

We'll need to host link images from GitHub

Already published the dev version here: https://pypi.org/project/whylogs/0.4.7.dev0/

@andyndang andyndang requested a review from lalmei May 2, 2021 16:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 804665428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 803549182: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2021

Pull Request Test Coverage Report for Build 805055867

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 803549182: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@andyndang andyndang merged commit 065a2cd into mainline May 2, 2021
@andyndang andyndang deleted the dev/andy/fix-readme-pypi branch May 2, 2021 22:12
@lalmei lalmei added the documentation Improvements or additions to documentation label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants