Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROV Logging Example #221

Merged
merged 6 commits into from
May 4, 2021
Merged

ROV Logging Example #221

merged 6 commits into from
May 4, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented May 3, 2021

No description provided.

@lalmei lalmei requested review from bernease and andyndang May 3, 2021 21:53
andyndang
andyndang approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei changed the title ROV Logging Example WIP: ROV Logging Example May 3, 2021
@coveralls
Copy link

coveralls commented May 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 810509658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 809034354: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

FelipeAdachi
FelipeAdachi reviewed May 4, 2021
View reviewed changes
examples/rov_whylogs/README.md
# Fault Detection of an Underwater Drone with Kafka and whylogs

This is the project's repository for the following article:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just add the link here once the article's published

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

FelipeAdachi
FelipeAdachi approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems.

@lalmei lalmei changed the title WIP: ROV Logging Example ROV Logging Example May 4, 2021
@lalmei lalmei merged commit ed3a9ce into mainline May 4, 2021
@lalmei lalmei deleted the ROV_exmaple branch May 4, 2021 15:48
@lalmei lalmei added the documentation Improvements or additions to documentation label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyndang andyndang andyndang approved these changes

@FelipeAdachi FelipeAdachi FelipeAdachi approved these changes

@bernease bernease Awaiting requested review from bernease

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lalmei @coveralls @andyndang @FelipeAdachi