Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature list based on checked inferred types #230

Merged
merged 1 commit into from
May 25, 2021
Merged

Update feature list based on checked inferred types #230

merged 1 commit into from
May 25, 2021

Conversation

valer-whylabs
Copy link
Contributor

The bug that is fixed with this PR:

  • Feature name list is being filtered as well, when we are changing the inferred type checkboxes.

lalmei
lalmei approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@lalmei lalmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 871991179

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 854988159: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@lalmei lalmei added the bug Something isn't working label May 25, 2021
@lalmei lalmei merged commit 97d1269 into whylabs:mainline May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalmei lalmei lalmei approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valer-whylabs @coveralls @lalmei