Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add String Tracker Notebook example link in README #252

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Add String Tracker Notebook example link in README #252

merged 2 commits into from
Jul 8, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 1, 2021

Description

add string notebook to readme

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the documentation Improvements or additions to documentation label Jul 1, 2021
@lalmei lalmei requested review from andyndang and cswarth July 1, 2021 20:05
@coveralls
Copy link

coveralls commented Jul 1, 2021 •
edited

Pull Request Test Coverage Report for Build 1009785920

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.915%
Totals Coverage Status
Change from base Build 1009755135: 0.0%
Covered Lines: 3349
Relevant Lines: 4022
💛 - Coveralls

@lalmei lalmei requested a review from samgracie July 6, 2021 16:13
@lalmei lalmei changed the title Add string notebook link to readme Update String Tracker notebook example link in Readme Jul 7, 2021
@lalmei lalmei changed the title Update String Tracker notebook example link in Readme I like this "Add String Tracker Notebook example link in README”" Jul 7, 2021
@lalmei lalmei changed the title I like this "Add String Tracker Notebook example link in README”" Add String Tracker Notebook example link in README Jul 7, 2021
cswarth
cswarth approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit 849ecc3 into mainline Jul 8, 2021
@lalmei lalmei deleted the update_README branch July 8, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswarth cswarth cswarth approved these changes

@andyndang andyndang Awaiting requested review from andyndang

@samgracie samgracie Awaiting requested review from samgracie

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lalmei @coveralls @cswarth