Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version bump script #258

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix version bump script #258

merged 1 commit into from
Jul 13, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 13, 2021 •
edited

Description

fixed script on version bump and bumped up a version

make bump-minor && make bump-release

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the bug Something isn't working label Jul 13, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1026947620

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.125%
Totals Coverage Status
Change from base Build 1024496285: 0.0%
Covered Lines: 3618
Relevant Lines: 4248
💛 - Coveralls

@lalmei lalmei enabled auto-merge (rebase) July 13, 2021 15:35
@andyndang
Copy link
Contributor

I'm probably missing some context here but why are we bumping up the version? Is it for prepping a release?

andyndang
andyndang approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit 5d179b6 into mainline Jul 13, 2021
@lalmei lalmei deleted the release_v0.5.0 branch July 13, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyndang andyndang andyndang approved these changes

@cswarth cswarth Awaiting requested review from cswarth

@naddeoa naddeoa Awaiting requested review from naddeoa

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lalmei @coveralls @andyndang