Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String tracker update with custom character list #263

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Jul 20, 2021

Description

Fix string tracker update with custom character list

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the bug Something isn't working label Jul 20, 2021
@lalmei lalmei requested a review from cswarth July 20, 2021 02:11
@lalmei lalmei enabled auto-merge (rebase) July 20, 2021 02:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1047333872

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 82.132%

Totals Coverage Status
Change from base Build 1047012755: 0.003%
Covered Lines: 3620
Relevant Lines: 4250

💛 - Coveralls

Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit fbb02c9 into mainline Jul 20, 2021
@lalmei lalmei deleted the fix_string_tracker_test branch July 20, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants