Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference package #282

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Remove reference package #282

merged 1 commit into from
Aug 14, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Aug 13, 2021

Description

Remove reference to scikit-learn

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the dependencies Pull requests that update a dependency file label Aug 13, 2021
@lalmei lalmei requested a review from andyndang August 13, 2021 23:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1129289124

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.034%
Totals Coverage Status
Change from base Build 1128933344: 0.0%
Covered Lines: 3614
Relevant Lines: 4248
💛 - Coveralls

@lalmei lalmei enabled auto-merge (rebase) August 13, 2021 23:43
cswarth
cswarth approved these changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@cswarth cswarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit 80d1b11 into mainline Aug 14, 2021
@lalmei lalmei deleted the remove_ghost_depend branch August 14, 2021 00:36
@lalmei lalmei mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswarth cswarth cswarth approved these changes

@andyndang andyndang Awaiting requested review from andyndang

@jamie256 jamie256 Awaiting requested review from jamie256

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lalmei @coveralls @cswarth