Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sagemaker and Flask Example #285

Merged
merged 22 commits into from
Aug 26, 2021
Merged

Sagemaker and Flask Example #285

merged 22 commits into from
Aug 26, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Aug 20, 2021 •
edited

Description

Sagemaker example for using whylogs with Whylabs

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added the documentation Improvements or additions to documentation label Aug 20, 2021
@coveralls
Copy link

coveralls commented Aug 20, 2021 •
edited

Pull Request Test Coverage Report for Build 1168575669

  • 22 of 33 (66.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 83.858%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/app/session.py 2 3 66.67%
src/whylogs/app/logger.py 14 18 77.78%
src/whylogs/app/utils.py 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
src/whylogs/app/logger.py 1 77.32%
Totals Coverage Status
Change from base Build 1164392617: -0.09%
Covered Lines: 3731
Relevant Lines: 4314
💛 - Coveralls

@lalmei lalmei enabled auto-merge (rebase) August 20, 2021 17:19
@lalmei lalmei added bug Something isn't working enhancement New feature or request labels Aug 25, 2021
@lalmei lalmei changed the title WIP: Sagemaker Example Sagemaker and Flask Example Aug 25, 2021
@lalmei lalmei requested a review from bernease August 25, 2021 22:29
auto-merge was automatically disabled August 26, 2021 15:57

Rebase failed

andyndang
andyndang approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyndang andyndang merged commit 14b969d into mainline Aug 26, 2021
@andyndang andyndang deleted the sagemaker_example branch August 26, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyndang andyndang andyndang approved these changes

@phantomgoose phantomgoose Awaiting requested review from phantomgoose

@cswarth cswarth Awaiting requested review from cswarth

@bernease bernease Awaiting requested review from bernease

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lalmei @coveralls @andyndang