Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload log statement #328

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix upload log statement #328

merged 1 commit into from
Oct 5, 2021

Conversation

jamie256
Copy link
Contributor

@jamie256 jamie256 commented Oct 5, 2021

Description

remove logging _api_key before it is set

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@jamie256 jamie256 added the bug Something isn't working label Oct 5, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1306652548

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.596%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/whylabs_client/wrapper.py 0 1 0.0%
Totals Coverage Status
Change from base Build 1305722685: 0%
Covered Lines: 3777
Relevant Lines: 4376

💛 - Coveralls

@jamie256 jamie256 merged commit d04f81b into mainline Oct 5, 2021
@jamie256 jamie256 deleted the dev/jamie/api_key_logging branch October 5, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants