SummaryConstraint: Table shape constraints #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taxuspt
suggested changes
Dec 30, 2021
added 9 commits
January 11, 2022 14:06
…le needed for implementation, modify DatasetConstraints accordingly, tests for table shape constraints and DatasetConstraints serialization
…rt. Modify the DatasetConstrains serialization test.
…ryConstraint.from_protobuf.
…d coerced value constraints
pecop2
force-pushed
the
dev/loka/table_shape_constraints
branch
from
d909dc9
to
76cd87f
Compare
jamie256
reviewed
Jan 18, 2022
jamie256
requested changes
Jan 20, 2022
Pull Request Test Coverage Report for Build 1746469670Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jamie256
approved these changes
Jan 21, 2022
jamie256
requested changes
Jan 21, 2022
…sts for sequential logging. Parameterize set length.
jamie256
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
columnExistsConstraint
numberOfRowsConstraint
columnsMatchSetConstraint
Evaluated using apply_table_shape_constraints
Attribute table_shape_constraints in DatasetConstraints
Attribute total_row_number in DatasetProfile
Tests for DatasetConstraints serialization/deserialization as changes in proto DatasetConstraintMsg were required
Tests for table shape constraints
General Checklist
if it was a bug, test must cover it.