MultiColumn Value Constraints #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time - initial implementation
…ltiColumnValueConstraintMsg
…protobuf in MultiColumnValueConstraint
…nt and MultiColumnValueConstraints. Change the way of tracking the dataframe at DatasetProfile. Constraint for column_values_A_greater_than_B and simple test for it.
…f and to_protobuf of MCVC, change OP CONTAINS_SET to CONTAIN_SET. Constraint functions for all the logical operations between two columns.
jamie256
requested changes
Jan 20, 2022
MilenaTrajanoska
changed the base branch from
dev/loka/constraints
to
mainline
# Conflicts: # proto/src/constraints.proto # src/whylogs/core/datasetprofile.py # src/whylogs/core/statistics/constraints.py # tests/unit/core/statistics/test_constraints.py
Pull Request Test Coverage Report for Build 1747299641Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
richard-rogers
requested changes
Jan 21, 2022
# Conflicts: # src/whylogs/core/statistics/constraints.py # tests/unit/core/statistics/test_constraints.py
jamie256
approved these changes
Jan 24, 2022
richard-rogers
approved these changes
Jan 25, 2022
# Conflicts: # proto/src/constraints.proto # src/whylogs/core/statistics/constraints.py # tests/unit/core/statistics/test_constraints.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
column_values_A_greater_than_B_constraint
column_values_A_greater_than_equal_B_constraint
column_values_A_less_than_B_constraint
column_values_A_less_than_equal_B_constraint
column_values_A_equal_B_constraint
column_values_A_not_equal_B_constraint
sumOfRowValuesOfMultipleColumnsEqualsConstraint
columnPairValuesInSetConstraint
columnValuesUniqueWithinRow
General Checklist
if it was a bug, test must cover it.