-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraints example notebook #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lots of examples here!
When ready can you update this PR on mainline?
- Can we rename the example file to something more descriptive than suffix of "2". I'm open to suggestions, but you can use something like "More_Constraints" if its hard to think of a good name.
- Can we include a few examples of constraints generation if there are updates there?
Pull Request Test Coverage Report for Build 1753147274Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…in Constraints_Suite.ipynb
…nto dev/loka/constraints_examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a method import error in the constraints notebook test, can you take a look?
ImportError: cannot import name 'numberOfRowsConstraint' from 'whylogs.core.statistics.constraints'
With 'numberOfRowsConstraint' being a part of the Table shape constraints PR that's not merged yet, that could be the problem. |
…g data more than once
…tting the row values when logging a dataframe.
Description
Example jupyter notebook for the new constraints.
Some of the constraints only work when switched to a certain branch, as not all the PRs are merged to mainline!
General Checklist
if it was a bug, test must cover it.