Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraints example notebook #417

Merged
merged 15 commits into from
Jan 26, 2022
Merged

Conversation

pecop2
Copy link
Contributor

@pecop2 pecop2 commented Jan 17, 2022

Description

Example jupyter notebook for the new constraints.

Some of the constraints only work when switched to a certain branch, as not all the PRs are merged to mainline!

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@pecop2 pecop2 changed the title Example notebook for the newly created constraints Constraints example notebook Jan 17, 2022
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lots of examples here!

When ready can you update this PR on mainline?

  • Can we rename the example file to something more descriptive than suffix of "2". I'm open to suggestions, but you can use something like "More_Constraints" if its hard to think of a good name.
  • Can we include a few examples of constraints generation if there are updates there?

@MilenaTrajanoska MilenaTrajanoska changed the base branch from dev/loka/constraints to mainline January 20, 2022 12:36
@coveralls
Copy link

coveralls commented Jan 21, 2022

Pull Request Test Coverage Report for Build 1753147274

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 35 of 36 (97.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 83.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/core/columnprofile.py 24 25 96.0%
Totals Coverage Status
Change from base Build 1752590615: 0.4%
Covered Lines: 4617
Relevant Lines: 5445

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a method import error in the constraints notebook test, can you take a look?

ImportError: cannot import name 'numberOfRowsConstraint' from 'whylogs.core.statistics.constraints' 

@pecop2
Copy link
Contributor Author

pecop2 commented Jan 25, 2022

Looks like there is a method import error in the constraints notebook test, can you take a look?

ImportError: cannot import name 'numberOfRowsConstraint' from 'whylogs.core.statistics.constraints' 

With 'numberOfRowsConstraint' being a part of the Table shape constraints PR that's not merged yet, that could be the problem.

@jamie256 jamie256 merged commit e5c6fc3 into mainline Jan 26, 2022
@jamie256 jamie256 deleted the dev/loka/constraints_examples branch January 26, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants