Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate wheel smoke test into standard CI workflow. #422

Merged
merged 14 commits into from
Jan 25, 2022

Conversation

richard-rogers
Copy link
Contributor

@richard-rogers richard-rogers commented Jan 24, 2022

Description

Adds a test that installs the built wheel into an "empty" virtual environment to simulate installation in a client environment (as opposed to the development environment) to ensure it contains all the required dependencies.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Jan 25, 2022

Pull Request Test Coverage Report for Build 1747078585

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on dev/richard/wheelcheck at 81.889%

Totals Coverage Status
Change from base Build 1743181373: 81.9%
Covered Lines: 4309
Relevant Lines: 5134

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description with a brief summary?

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-rogers richard-rogers merged commit 6bc0957 into mainline Jan 25, 2022
@richard-rogers richard-rogers deleted the dev/richard/wheelcheck branch January 25, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants