Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change total row number computation #427

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

pecop2
Copy link
Contributor

@pecop2 pecop2 commented Jan 27, 2022

Description

Changed the way of computing the total_row_number used for the Table shape constraints, using each column profile counters tracker instead of creating and updating a separate dictionary. This as well addresses the concern of merging two dataset profiles and possibility of inconsistencies when using a separate dictionary for tracking the total row number.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@pecop2 pecop2 requested a review from jamie256 January 27, 2022 16:49
@coveralls
Copy link

coveralls commented Jan 27, 2022

Pull Request Test Coverage Report for Build 1757541588

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 83.026%

Totals Coverage Status
Change from base Build 1753562618: -0.003%
Covered Lines: 4614
Relevant Lines: 5442

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up here, looks good!

@jamie256 jamie256 merged commit b5769f5 into mainline Jan 27, 2022
@jamie256 jamie256 deleted the dev/loka/table_shape_total_row_number branch January 27, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants