Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/loka/jupyter notebook visualization #433

Merged
merged 150 commits into from
Mar 15, 2022
Merged

Dev/loka/jupyter notebook visualization #433

merged 150 commits into from
Mar 15, 2022

Conversation

Jirayr-Solvee
Copy link
Contributor

Description

This PR gives ability to get list of visualizations for profiled data inside jupyter notebook

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

Perch2005 and others added 30 commits December 23, 2021 23:25
@Perch2005
visualizer new design, add reference profile in profile viewer
a89ecf2
@Perch2005
add json reference profile button, add UI changes
4149338
@Perch2005
change view detail button position, change referenceProfilePanel char…
1cfc2da 
…t view, add icons
@Perch2005
add property panel for reference profile, charts for json profile wit…
aed8c83 
…hout reference
@Perch2005
add the notification sign of filter button
0341dc0
@Perch2005
change the chart color at referenceProfilePanel
9e98586
@Perch2005
add the notification sign of filter button
de42093
@Perch2005
add the notification sign of filter button
6b911f9
@Perch2005
add selected file name
054f938
@Perch2005
use addFileName() function when the file is load
af917f7
@Perch2005
add "Filter by type" design changes, add "Quick search" design changes.
4381751
@Perch2005
add delete and edit buttons for reference profile.
7c314ef
@Perch2005
add blue notification sign for opening the text of sign up
5e26dda
@Perch2005
add blue notification sign for opening the text of sign up
7c68bd6
@Perch2005
add "Filter by type" design changes, add "Quick search" design changes.
ec20948
@Perch2005
add "Quick search" input.
d30aeab
@Perch2005
count of types in "filter by type" dropdown
cc42082
@Perch2005
position of edit, delete buttons sticky.
876561e
@Perch2005
add double histogram chart in reference profile panel.
88e984c
@Perch2005
"Sign up for a free WhyLabs account" button disappears when screen wi…
ff74345 
…th less than 1000px.
@ssxcho
add reference profile charts, add profile name and time stamp
d893476
@ssxcho
add reference profile charts, add profile name and time stamp
ff4fad1
@ssxcho
add diff from ref when reference profile consists.
da0dbf2
@ssxcho
add diff from ref when reference profile consists.
8ea2d0c
@ssxcho
fix reference profile time stamp appear place.
0cd2c41
@ssxcho
fix multi profile logic, fix css
63a65dc
@Perch2005
fix data of Frequent items table cell
b7f5aa1
@Perch2005
Shows alert when the key of profile data is not matched to reference …
c736a77 
…profile data.
@Perch2005
histograms visualisation in jupyter notebook
35fafd6
@ssxcho
add backend for jupyter notebook vizualisation, add jupyter notebook …
abb5740 
…to display profile data in the notebook
@jamie256 jamie256 mentioned this pull request Feb 22, 2022
Closed
Perch2005 and others added 20 commits February 26, 2022 04:11
@Perch2005
change double histogram generating logic
773fba5
@Perch2005
add error handling
5300be6
@Perch2005
change differenced bar chart logic
b936bf8
@Perch2005
change bar chart generating logic
c9e5f69
@Perch2005
Remove drift color dots from the legends
305aa78
@Perch2005
increase font size for all table values
05b1284
@Perch2005
change drift ranges style
badf761
@Perch2005
add tool tips to explain the statistic used for the diff from ref
6d7a643
@Perch2005
change number abbreviation logic
3102460
@Perch2005
remove drift color dots from the drift column
857552f
@Perch2005
right align all the data in the Feature table columns (diff from ref,…
2f229a6 
… count, mean)
@Perch2005
change Full Profile Summary Statistics chart generating logic
957a976
@Perch2005
change chart colors
054ed54
@Perch2005
add error message when feature invalid
d7f549a
@Perch2005
change passed to green
aaf5ee5
@Perch2005
looping through bins instead of counts
de4130b
@Perch2005
change the logic of getting the width of the bars
83d6e28
@Jirayr-Solvee
Merge branch 'mainline' into dev/loka/jupyter_notebook_visualization
892bd3b
@Perch2005
fix: reduce chart colors opacity to 60%
be917df
@Perch2005
Merge branch 'dev/loka/jupyter_notebook_visualization' of https://git…
2fd6872 
…hub.com/whylabs/whylogs into dev/loka/jupyter_notebook_visualization
@FelipeAdachi
Copy link
Contributor

  • double_histogram: For all of the mixture features, it seems there's a long tail on the X-axis, all the way to 3.0, when max values go up to 1.2~1.3. We can see an example in the attached image. This sould be reproducible directly from the code in Profile_Viewer_In_Notebook.

  • double_histogram: Another issue on double_histogram is the shape of the bins: in some cases, for the mixture_distributions, the bins have a large width and seem to overlap. The attached image is also an example of that. This sould be reproducible directly from the code in Profile_Viewer_In_Notebook

image-20220301-203413

jamie256 and others added 4 commits March 8, 2022 10:30
@jamie256
Merge branch 'mainline' into dev/loka/jupyter_notebook_visualization
5ce3a27
@jamie256
Merge branch 'mainline' into dev/loka/jupyter_notebook_visualization
877e2da
@FelipeAdachi
Histogram Bin Width and Range (#468)
a8e3a33 
- Changed upper value of domain's xscale to match the max between both distribution's -> max of bin value + bin_width
- apply Xscale to each of distribution's [1] and [0] before calculating bar width, instead of scaling the difference ([1]-[0])
@jamie256
Merge branch 'mainline' into dev/loka/jupyter_notebook_visualization
f292351
@jamie256 jamie256 merged commit 5a34cf5 into mainline Mar 15, 2022
@jamie256 jamie256 deleted the dev/loka/jupyter_notebook_visualization branch March 15, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jirayr-Solvee @coveralls @FelipeAdachi @jamie256 @Perch2005 @ssxcho