Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatasetConstraints serialization and chi square calculation fixes #437

Merged
merged 10 commits into from
Feb 15, 2022

Conversation

pecop2
Copy link
Contributor

@pecop2 pecop2 commented Feb 9, 2022

Description

Fixing a serializing bug for DatasetConstraints that contained MultiColumnConstraints and updating the tests.
Fix for Chi-Squared statistic calculation.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Feb 9, 2022

Pull Request Test Coverage Report for Build 1841873043

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 24 (87.5%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 82.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/core/summaryconverters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
src/whylogs/proto/constraints_pb2.py 9 67.33%
Totals Coverage Status
Change from base Build 1824832732: 0.07%
Covered Lines: 4745
Relevant Lines: 5596

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making the fixes and refactor.

@jamie256 jamie256 merged commit 37cec2f into mainline Feb 15, 2022
@jamie256 jamie256 deleted the dev/loka/serialization_and_calculations_fix branch February 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants