Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KS test p-value computation #444

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Fix KS test p-value computation #444

merged 4 commits into from
Feb 21, 2022

Conversation

MilenaTrajanoska
Copy link
Contributor

Description

Fix KS test p-value computation
Add condition in entropy calculation

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Feb 16, 2022 •
edited

Pull Request Test Coverage Report for Build 1866975240

  • 21 of 28 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 82.512%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/core/summaryconverters.py 21 28 75.0%
Files with Coverage Reduction New Missed Lines %
src/whylogs/core/summaryconverters.py 1 82.54%
Totals Coverage Status
Change from base Build 1865463166: -0.09%
Covered Lines: 4761
Relevant Lines: 5620
💛 - Coveralls

@bernease
Copy link
Contributor

Looking into this later today.

jamie256
jamie256 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit 78bcac5 into mainline Feb 21, 2022
@jamie256 jamie256 deleted the dev/loka/statistics_fix branch February 21, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@pecop2 pecop2 Awaiting requested review from pecop2

@bernease bernease Awaiting requested review from bernease

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MilenaTrajanoska @coveralls @bernease @jamie256