Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix build for Spark and Scala versions #447

Merged
merged 29 commits into from
Mar 15, 2022
Merged

Conversation

richard-rogers
Copy link
Contributor

Description

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Feb 18, 2022

Pull Request Test Coverage Report for Build 1954170173

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 82.549%

Totals Coverage Status
Change from base Build 1930805768: -0.01%
Covered Lines: 4764
Relevant Lines: 5621

💛 - Coveralls

@andyndang
Copy link
Contributor

FYI at some point Spark 3.x deprecates Scala 2.11, so you should only build it for Spark 2.x

And from Spark 3.2.0, they support Scala 2.13

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamie256 jamie256 merged commit d6d07c0 into mainline Mar 15, 2022
@jamie256 jamie256 deleted the dev/richard/matrix branch March 15, 2022 16:01
jamie256 added a commit that referenced this pull request Mar 15, 2022
jamie256 added a commit that referenced this pull request Mar 15, 2022
@richard-rogers richard-rogers restored the dev/richard/matrix branch March 16, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants