Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced kstest p-value calculation to match scipy's ks_2samp #483

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

FelipeAdachi
Copy link
Contributor

Description

KS drift values were erroneous. Changed p-value calculation to match scipy's asymptotic distribution mode of ks_2samp.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for walking through these changes, looks good!

@coveralls
Copy link

coveralls commented Mar 22, 2022

Pull Request Test Coverage Report for Build 2024461011

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 82.58%

Totals Coverage Status
Change from base Build 2023610524: 0.002%
Covered Lines: 4935
Relevant Lines: 5811

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants