Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yscale on double histogram notebook chart #485

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

jamie256
Copy link
Contributor

Fixes #479 - issue is that the yscale only considered one of the profiles max values when scaling the y axis, which could truncate the bars in one of the profiles.

Also some incidental minor fixes:
Remove placeholder tooltip text, consistently use "target" instead of "current" terminology when comparing profiles.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@jamie256 jamie256 added the bug Something isn't working label Mar 23, 2022
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

coveralls commented Mar 23, 2022

Pull Request Test Coverage Report for Build 2029666146

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.58%

Totals Coverage Status
Change from base Build 2025072305: 0.0%
Covered Lines: 4935
Relevant Lines: 5811

💛 - Coveralls

@jamie256 jamie256 enabled auto-merge (squash) March 23, 2022 18:36
@jamie256 jamie256 merged commit 1567bfe into mainline Mar 23, 2022
@jamie256 jamie256 deleted the dev/jamie/yscale branch March 23, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distribution_chart crops the plot for big differences between distributions
3 participants