Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't slice using negative indexes to filter bar charts #496

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

jamie256
Copy link
Contributor

@jamie256 jamie256 commented Mar 29, 2022

Description

We search for undefined values to filter them, but then also use the -1 to slice the arrays, resulting in wrapping around to the first element and double rendering some bins on our NotebookProfilerViewer charts. The double rendering appears darker with the use of opacity.

The fix is to not try to change the data if there are no undefined values in the findAndDeleteUndefined function.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Mar 29, 2022

Pull Request Test Coverage Report for Build 2056529968

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.58%

Totals Coverage Status
Change from base Build 2035476573: 0.0%
Covered Lines: 4935
Relevant Lines: 5811

💛 - Coveralls

Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit 324ec87 into mainline Mar 29, 2022
@jamie256 jamie256 deleted the dev/jamie/filter_undefined branch March 29, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants