Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pvalue=0 needs to be evaluated as True #498

Merged
merged 4 commits into from
Mar 29, 2022
Merged

pvalue=0 needs to be evaluated as True #498

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32632fd
remove % symbol for total count of missing values
FelipeAdachi Mar 29, 2022
3ad3cdd
changed if statement to prevent pvalue of 0 evaluated as False
FelipeAdachi Mar 29, 2022
ed9d9c5
Merge branch 'mainline' into undefinedpval
jamie256 Mar 29, 2022
6524918
Merge branch 'mainline' into undefinedpval
jamie256 Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/whylogs/viewer/templates/index-hbs-cdn-all-in-for-jupyter-notebook.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
Handlebars.registerHelper("missingCells", function (properties) {
const {value, newValue, suffixe} = abbreviate_number(referenceProfile.properties.missing_cells)
if (typeof value !== 'undefined' && typeof newValue !== 'undefined' && typeof suffixe !== 'undefined' ) {
return numberWithSuffixe(value, valueSuffixe(`(${newValue}%)`), suffixe);
return numberWithSuffixe(value, valueSuffixe(`${newValue}`), suffixe);
}
return numberWithSuffixe(0, valueNumber(0), valueNumber(''));
});
Expand Down
2 changes: 1 addition & 1 deletion src/whylogs/viz/utils/profile_viz_calculations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def add_drift_val_to_ref_profile_json(target_profile, reference_profile, referen
frequent_items=reference_frequent_items_sketch.to_summary(), total_count=ref_total_count
)
chi_squared_p_value = compute_chi_squared_test_p_value(target_message, reference_message)
if chi_squared_p_value.chi_squared_test:
if chi_squared_p_value.chi_squared_test is not None:
reference_profile_json["columns"][target_col_name]["drift_from_ref"] = chi_squared_p_value.chi_squared_test
else:
reference_profile_json["columns"][target_col_name]["drift_from_ref"] = None
Expand Down