Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict bin count based on numeric precision on kll floats sketch #519

Merged
merged 5 commits into from
Apr 7, 2022

Conversation

jamie256
Copy link
Contributor

@jamie256 jamie256 commented Apr 6, 2022

Description

Addresses #518 by reducing the bin count if the width of the bins is lower than rounding of the values.

This is a mitigation for the conversion of profile to summary which uses a default bin count that doesn't work in some cases. We still could use some follow up to better track larger integers not well captured by the floats sketch.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 2111352590

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 82.661%

Totals Coverage Status
Change from base Build 2110893254: 0.05%
Covered Lines: 4962
Relevant Lines: 5838

💛 - Coveralls

Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/whylogs/core/summaryconverters.py Show resolved Hide resolved
src/whylogs/core/summaryconverters.py Outdated Show resolved Hide resolved
src/whylogs/core/summaryconverters.py Outdated Show resolved Hide resolved
@jamie256 jamie256 enabled auto-merge (squash) April 7, 2022 20:23
@jamie256 jamie256 merged commit c9f8680 into mainline Apr 7, 2022
@jamie256 jamie256 deleted the dev/jamie/bin_count branch April 7, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants