Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Started documentation maintence #522

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Getting Started documentation maintence #522

merged 2 commits into from
Apr 8, 2022

Conversation

TheMellyBee
Copy link
Contributor

@TheMellyBee TheMellyBee commented Apr 7, 2022 •
edited
Loading

Description

  1. Removes the unused whylogs-demo from the getting started to remo481ve confusion.
  2. Broken link in documentation on create a logger #481 links to the GitHub page for the correct example code

General Checklist

  • Documentation updated
  • (optional) Please add a label to your PR

@TheMellyBee TheMellyBee added the documentation Improvements or additions to documentation label Apr 7, 2022
@coveralls
Copy link

coveralls commented Apr 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2111987406

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 82.687%
Totals Coverage Status
Change from base Build 2111550501: 0.03%
Covered Lines: 4963
Relevant Lines: 5838
💛 - Coveralls

@TheMellyBee TheMellyBee changed the title Removes the demo init from the getting statrted docs. Getting Started documentation maintence Apr 7, 2022
FelipeAdachi
FelipeAdachi approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jamie256
jamie256 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@jamie256 jamie256 merged commit 79039ca into mainline Apr 8, 2022
@jamie256 jamie256 deleted the read-the-docs branch April 8, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelipeAdachi FelipeAdachi FelipeAdachi approved these changes

@jamie256 jamie256 jamie256 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheMellyBee @coveralls @FelipeAdachi @jamie256