Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HTML display for mismatching number of frequent items between profiles #536

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

FelipeAdachi
Copy link
Contributor

Description

When reference_profile had a higher number of frequentItems than target_profile, profile_viewer generated broken HTML file, because the logic iterated on target_profile and used index to try to access reference_profile.

Changed to:

  • Iterate based on min. number of frequentItems
  • frequentItem Strings loaded w/ empty string when trying to access not-existing index

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Apr 11, 2022

Pull Request Test Coverage Report for Build 2151064729

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.661%

Totals Coverage Status
Change from base Build 2116364606: 0.0%
Covered Lines: 4962
Relevant Lines: 5838

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find on the root cause Felipe, thanks for getting this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants