Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[viz] Axis fix for histogram and distribution chart #569

Merged
merged 3 commits into from
May 20, 2022

Conversation

FelipeAdachi
Copy link
Contributor

Description

  • added nice() to domain to get rounded numbers in domain
  • added multiplier so data would fall withing yaxis ticks
  • removed unnecessary variables

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

- Ints mapped to kstest instead of Chisquared
- chisquared - erroneous dof calc due to absent unique count
Copy link
Contributor

@TheMellyBee TheMellyBee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@coveralls
Copy link

coveralls commented May 20, 2022

Pull Request Test Coverage Report for Build 2359829148

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.631%

Totals Coverage Status
Change from base Build 2359514945: 0.0%
Covered Lines: 4967
Relevant Lines: 5845

💛 - Coveralls

@FelipeAdachi FelipeAdachi merged commit d092535 into whylabs:mainline May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants