Update RIR links and remove sanitized ampersands #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QEDK
commented
Apr 24, 2020
QEDK
commented
- Remove breaking sanitized ampersands
- AFRINIC WHOIS web UI is now replaced and only works with POST
- RIPE has a new pathway
* Remove breaking sanitized ampersands * AFRINIC WHOIS web UI is now replaced and only works with POST * RIPE has a new pathway
whym
reviewed
Apr 27, 2020
public_html/gateway.py
Outdated
| 'RIPENCC': 'https://apps.db.ripe.net/search/query.html?searchtext={0}#resultsAnchor', | ||
| 'AFRINIC': 'http://afrinic.net/cgi-bin/whois?searchtext={0}', | ||
| 'RIPENCC': 'https://apps.db.ripe.net/db-web-ui/query?searchtext={0}', | ||
| 'AFRINIC': 'https://www.afrinic.net/whois-web/public/?lang=en', |
There was a problem hiding this comment.
I believe the user is supposed to paste the IP into the AFRINIC form manually with this. I'd like to see the instruction somewhere explicitly. Maybe in the link anchor or in the tooltip. We might want to skip AFRINIC in the "Location:" redirection, too.
There was a problem hiding this comment.
Changed it to RDAP, provides the same information, just ugly.
whym
reviewed
Apr 28, 2020
| @@ -20,7 +20,7 @@ | |||
| PROVIDERS = { | |||
| 'ARIN': 'https://whois.arin.net/rest/ip/{0}', | |||
| 'RIPENCC': 'https://apps.db.ripe.net/db-web-ui/query?searchtext={0}', | |||
| 'AFRINIC': 'https://www.afrinic.net/whois-web/public/?lang=en', | |||
| 'AFRINIC': 'https://rdap.afrinic.net/rdap/ip/{0}', | |||
| 'APNIC': 'https://wq.apnic.net/apnic-bin/whois.pl?searchtext={0}', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.