Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RIR links and remove sanitized ampersands

Merged
merged 3 commits into from Apr 28, 2020
Merged

Update RIR links and remove sanitized ampersands #15

merged 3 commits into from Apr 28, 2020

Conversation

QEDK
Copy link
Contributor

@QEDK QEDK commented Apr 24, 2020

  • Remove breaking sanitized ampersands
  • AFRINIC WHOIS web UI is now replaced and only works with POST
  • RIPE has a new pathway

* Remove breaking sanitized ampersands
* AFRINIC WHOIS web UI is now replaced and only works with POST
* RIPE has a new pathway
@QEDK QEDK mentioned this pull request Apr 24, 2020
'RIPENCC': 'https://apps.db.ripe.net/search/query.html?searchtext={0}#resultsAnchor',
'AFRINIC': 'http://afrinic.net/cgi-bin/whois?searchtext={0}',
'RIPENCC': 'https://apps.db.ripe.net/db-web-ui/query?searchtext={0}',
'AFRINIC': 'https://www.afrinic.net/whois-web/public/?lang=en',
Copy link
Owner

@whym whym Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the user is supposed to paste the IP into the AFRINIC form manually with this. I'd like to see the instruction somewhere explicitly. Maybe in the link anchor or in the tooltip. We might want to skip AFRINIC in the "Location:" redirection, too.

Copy link
Contributor Author

@QEDK QEDK Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to RDAP, provides the same information, just ugly.

@QEDK QEDK requested a review from whym Apr 27, 2020
@@ -20,7 +20,7 @@
PROVIDERS = {
'ARIN': 'https://whois.arin.net/rest/ip/{0}',
'RIPENCC': 'https://apps.db.ripe.net/db-web-ui/query?searchtext={0}',
'AFRINIC': 'https://www.afrinic.net/whois-web/public/?lang=en',
'AFRINIC': 'https://rdap.afrinic.net/rdap/ip/{0}',
'APNIC': 'https://wq.apnic.net/apnic-bin/whois.pl?searchtext={0}',
Copy link
Owner

@whym whym Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. 👍

@whym whym merged commit f7e7e60 into whym:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants